RFC: INITIALIZE_DEFAULT / FINALIZE_DEFAULT => initialize! / finalize! #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to be able to define callbacks that have predefined initializer/finalizers, e.g. ``` struct Diagnostics # some stuff end DiffEqBase.initialize!(d::Diagnostics, u, t, integrator) = # set up stuff DiffEqBase.finalize!(d::Diagnostics, u, t, integrator) = # finalize stuff DiscreteCallback(mycond, Diagnostics(details)) # don't need to pass explicit initializer / finalizer functions ``` We could do this now by defining additional methods for `INITIALIZE_DEFAULT` / `FINALIZE_DEFAULT`, but this seems a bit clearer. If you're on board, I can add some docs.
simonbyrne
changed the title
|
Okay, I realise this won't quite work as it is passed the I'll need to think a bit more about this. |
|
What I had in mind was something like this: |
|
Yeah I see what you're getting at. Usually for this kind of thing I'd make a callable type will all of the function dispatches and pass that type in all spots, but the init and finalize functions would clash so that's a little tricky. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure what you think about this, but we want to be able to define callbacks that have predefined initializer/finalizers, e.g.
We could do this now by defining additional methods for
INITIALIZE_DEFAULT/FINALIZE_DEFAULT, but this seems a bit clearer.If you're on board, I can add some docs.